-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(amplifier)!: amplifier gateway v2 #154
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #154 +/- ##
==========================================
+ Coverage 96.80% 98.14% +1.33%
==========================================
Files 47 47
Lines 752 755 +3
Branches 158 156 -2
==========================================
+ Hits 728 741 +13
+ Misses 4 1 -3
+ Partials 20 13 -7 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think one could pass rotate signers into approve messages and vice versa, which is potentially dangerous.
Discussed offline, but adding here for completeness. The data hash being signed also depends on |
AXE-3660
Breaking events
ContractCallApproved
now includes themessageId
instead of tx hash and event index separatelySignersRotated
event is used instead ofOperatorshipTransferred
to adhere to the updated naming conventioncommandId
derivation has changed. SeemessageToCommandId
here. It's still guaranteed to be globally unique.