Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(amplifier)!: amplifier gateway v2 #154

Merged
merged 46 commits into from
Apr 10, 2024
Merged

Conversation

milapsheth
Copy link
Member

@milapsheth milapsheth commented Apr 8, 2024

AXE-3660

  • fix tests

Breaking events

  • ContractCallApproved now includes the messageId instead of tx hash and event index separately
  • SignersRotated event is used instead of OperatorshipTransferred to adhere to the updated naming convention

commandId derivation has changed. See messageToCommandId here. It's still guaranteed to be globally unique.

@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.14%. Comparing base (aa421a9) to head (a006f21).

❗ Current head a006f21 differs from pull request most recent head 8d5160a. Consider uploading reports for the commit 8d5160a to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #154      +/-   ##
==========================================
+ Coverage   96.80%   98.14%   +1.33%     
==========================================
  Files          47       47              
  Lines         752      755       +3     
  Branches      158      156       -2     
==========================================
+ Hits          728      741      +13     
+ Misses          4        1       -3     
+ Partials       20       13       -7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@milapsheth milapsheth marked this pull request as ready for review April 9, 2024 10:38
@milapsheth milapsheth requested a review from a team as a code owner April 9, 2024 10:38
Copy link
Contributor

@Foivos Foivos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think one could pass rotate signers into approve messages and vice versa, which is potentially dangerous.

Base automatically changed from refactor/weighted-multisig to main April 10, 2024 03:18
@milapsheth milapsheth enabled auto-merge (squash) April 10, 2024 05:27
@milapsheth milapsheth merged commit 4b4ca7d into main Apr 10, 2024
5 checks passed
@milapsheth milapsheth deleted the feat/amplifier-gateway-v2 branch April 10, 2024 05:29
@milapsheth milapsheth restored the feat/amplifier-gateway-v2 branch April 10, 2024 05:29
@milapsheth
Copy link
Member Author

milapsheth commented Apr 10, 2024

I think one could pass rotate signers into approve messages and vice versa, which is potentially dangerous.

Discussed offline, but adding here for completeness. The data hash being signed also depends on CommandType which isn't user controlled and avoids this issue.

@milapsheth milapsheth deleted the feat/amplifier-gateway-v2 branch April 23, 2024 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants