chore: stellar-t1-2025-q1 devnet-amplifier deployment #527
Conversation
RiceAndMeet
changed the title
| @@ -961,6 +1020,21 @@ | |||
| "codeId": 854, | |||
| "address": "axelar1s3g877l0pk958vzeyrev9vncklrfht7dx2xv9c4u7zmr0y7jzfmq5cxjqm" | |||
| }, | |||
| "stellar-t1-2025-q1": { | |||
There was a problem hiding this comment.
| "stellar-t1-2025-q1": { | |
| "stellar-2024-q4": { |
how did you choose the name? For official deployments, the name should be chosen carefully. In this case, we're adding the Stellar testnet from Q4 2024
There was a problem hiding this comment.
The logic here is to name it based on when stellar instance is being deployed, hence 2025-q1. t1 is an counter we increment if multiple reset is happened within same quarter, which maybe likely considering this is devnet.
There was a problem hiding this comment.
We should consider that there might be multiple deployments in the same quarter just in case, having increment factors like t1, t2 or test1, test2 is necessary. FYI there will be a testnet reset in March 2025, so we should expect a new deployment in Q1, 2025.
There was a problem hiding this comment.
I am ok with the pattern of testnet release time and an counter stellar-[counter]-[stellar release], so in this case it would be stellar-t1-2024-q4 . This would cover all the criteria mentioned.
There was a problem hiding this comment.
We can use: stellar-[stellar testnet release]-[optional counter only if needed]
stellar-2024-q4
stellar-2024-q4-2
...
stellar-2025-q1
stellar-2025-q1-2
| "decimals": 7, | ||
| "finality": "1", | ||
| "approxFinalityWaitTime": 1, | ||
| "tokenSymbol": "XLM", |
There was a problem hiding this comment.
We should have XLM tokenAddress in the config: https://github.com/axelarnetwork/axelar-contract-deployments/blob/main/axelar-chains-config/info/devnet-amplifier.json#L636-L637
- testnet:
CDLZFC3SYJYDZT7K67VZ75HPJVIEUVNIXF47ZG2FB2RMQQVU2HHGCYSC - mainnet:
CAS3J7GYLGXMF6TDJBBYYSE3HQ6BBSMLNUQ34T6TZMYMW2EVH34XOWMA
| } | ||
| } | ||
| } | ||
| }, | ||
| "stellar-test-2025-q1": { |
There was a problem hiding this comment.
Given agreed naming convention does this need to be updated or deprecated?
No description provided.