feat: deploy gas service v6.1 with operators contract on testnet #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
milapsheth
commented
Sep 13, 2023
milapsheth
commented
- Improve gas service deployment
- Add Operators deployment
- Add gas service upgrade deployment
milapsheth
requested review from
re1ro,
Foivos and
deanamiel
as code owners
| @@ -148,6 +159,8 @@ async function processCommand(options, chain) { | |||
|
|
|||
| printInfo(`New contract owner: ${newOwner}`); | |||
|
|
|||
| contractConfig.owner = newOwner; | |||
There was a problem hiding this comment.
Should we also store pending owner in the config?. If yes then we can check if the caller doing acceptOwnership is the same address as that from the config. At last after accepting we can clear out this value.
There was a problem hiding this comment.
we're already checking if the pending owner retrieved from the contract is the same as wallet address. i'd avoid storing since it's transient data. we can try it in the future if we find a need for it?
deanamiel
reviewed
Sep 13, 2023
deanamiel
approved these changes
Sep 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.