feat: script to manage ownership #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
milapsheth
reviewed
Aug 28, 2023
|
https://github.com/axelarnetwork/axelar-gmp-sdk-solidity/blob/main/contracts/interfaces/IOwnable.sol This interface implements both:
Why have we implemented both options? |
My understanding is that it provides more flexibility. There may be some circumstances where we want to perform a single step ownership transfer, but other instances where it would be more secure to perform a 2-step transfer where the proposed owner has to accept the ownership role. Not only for us, but also for developers using our SDK. |
milapsheth
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Script to manage ownership for all contracts that inherit the SDK Ownable.sol as per AXE-1594:
https://axelarnetwork.atlassian.net/browse/AXE-1594