Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: contract verification script failing for fantom and scroll #212

Merged
merged 13 commits into from
May 13, 2024
Merged

fix: contract verification script failing for fantom and scroll #212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
12a5eb7
fix: add try catch to continue verifying if task fails for fantom tes…
blockchainguyy Apr 15, 2024
77a7842
refactor: update explorer for scroll mainnet
blockchainguyy Apr 15, 2024
be3a728
refactor: console chain name instead of object
blockchainguyy Apr 15, 2024
53ada0c
Merge branch 'main' into fix/verification-script
blockchainguyy Apr 17, 2024
09eacc6
Merge branch 'main' into fix/verification-script
blockchainguyy Apr 30, 2024
ad6d4a2
Merge branch 'main' into fix/verification-script
blockchainguyy May 2, 2024
4e0cef6
refactor: replace execSync with exec
blockchainguyy May 2, 2024
c5dc1ae
Merge branch 'main' into fix/verification-script
blockchainguyy May 3, 2024
a755ddc
chore: use try catch with execsync
blockchainguyy May 6, 2024
e6a4aa3
chore: pipe stderr and stdout while running cmd
blockchainguyy May 6, 2024
333a8e8
Merge branch 'main' into fix/verification-script
blockchainguyy May 9, 2024
63a81d4
chore: update error statement
blockchainguyy May 13, 2024
b59e6a6
Merge branch 'main' into fix/verification-script
blockchainguyy May 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions axelar-chains-config/info/mainnet.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1859,8 +1859,8 @@
},
"explorer": {
"name": "Scroll Explorer",
"url": "https://blockscout.scroll.io",
"api": "https://blockscout.scroll.io/api"
"url": "https://scrollscan.com/",
"api": "https://api.scrollscan.com/api"
},
"confirmations": 2,
"gasOptions": {
Expand Down
13 changes: 10 additions & 3 deletions axelar-chains-config/src/utils/verifyContract.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,16 @@ const verifyContract = (env, chain, contract, args, options = {}) => {
console.log(`Verifying contract ${contract} with args '${stringArgs.join(',')}'`);
console.log(cmd);

execSync(cmd, { stdio: 'inherit' });
blockchainguyy marked this conversation as resolved.
Show resolved Hide resolved

console.log('Verified!');
try {
execSync(cmd, { stdio: ['inherit', 'pipe', 'pipe'] });
console.log('Verified!');
} catch (error) {
if (error.message.includes('Reason: Already Verified')) {
console.log(`Contract ${contract} is already verified on ${chain.toLowerCase()}.`);
} else {
throw new Error(`An error occurred while trying to verify ${contract} on ${chain.toLowerCase()}:\n${error}`);
}
}
};

module.exports = {
Expand Down
Loading