feat: add script to generate block finality difference #188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deanamiel
reviewed
Mar 13, 2024
deanamiel
reviewed
Mar 13, 2024
deanamiel
reviewed
Mar 13, 2024
deanamiel
reviewed
Mar 13, 2024
deanamiel
reviewed
Mar 13, 2024
deanamiel
reviewed
Mar 13, 2024
deanamiel
approved these changes
Mar 13, 2024
milapsheth
reviewed
Mar 13, 2024
|
what is finalized representing ? if the value is not directly used or passed ahead, finalized-tag would be more descriptive than just finalized, if i am reading this correctly. |
Its representing what should be used for ensuring finality for a block on chain, its either "finalized" , or the number of block confirmations to wait before considering it final. So I don't think it should be "finalized-tag". |
milapsheth
reviewed
Mar 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://axelarnetwork.atlassian.net/browse/AXE-3338