Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(scripts): miscellaneous corrections #15

Merged
merged 3 commits into from
Jul 12, 2023
Merged

fix(scripts): miscellaneous corrections #15

merged 3 commits into from
Jul 12, 2023

Conversation

jcs47
Copy link
Contributor

@jcs47 jcs47 commented Jul 12, 2023 •
edited
Loading

  • Allow regular http get request
  • import ConstAddressDeployer and ConstCreate3Deployer from axelar-network/axelar-gmp-sdk-solidity repo
  • use correct function name for deploying contract at evm/deploy-const-address-deployer.js
  • check that governance chain address is a string, but not an EVM address
  • ran linter and prettier

@jcs47 jcs47 merged commit 3416d66 into main Jul 12, 2023
@jcs47 jcs47 deleted the fixes branch July 12, 2023 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deanamiel deanamiel deanamiel approved these changes

@re1ro re1ro Awaiting requested review from re1ro

@Foivos Foivos Awaiting requested review from Foivos

@milapsheth milapsheth Awaiting requested review from milapsheth

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jcs47 @deanamiel