Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Governance): dedicated withdraw method and safety checks #220

Merged
merged 8 commits into from
Aug 3, 2023
Merged

feat(Governance): dedicated withdraw method and safety checks #220

merged 8 commits into from
Aug 3, 2023

Conversation

re1ro
Copy link
Contributor

@re1ro re1ro commented Aug 2, 2023

  • Governance: dedicated withdraw method that can only be called via proposal
  • Caller: checking if target is a contract
  • Governance: _getProposalHash to use abi.encode

@re1ro re1ro requested a review from deanamiel August 2, 2023 15:50
@re1ro re1ro self-assigned this Aug 2, 2023
milapsheth
milapsheth approved these changes Aug 2, 2023
View reviewed changes
contracts/governance/InterchainGovernance.sol Outdated Show resolved Hide resolved
contracts/interfaces/IInterchainGovernance.sol Outdated Show resolved Hide resolved
re1ro and others added 2 commits August 2, 2023 15:59
@re1ro @milapsheth
Update contracts/governance/InterchainGovernance.sol
902b2f0 
Co-authored-by: Milap Sheth <milap@axelar.network>
@re1ro @milapsheth
Update contracts/interfaces/IInterchainGovernance.sol
cab3478 
Co-authored-by: Milap Sheth <milap@axelar.network>
milapsheth
milapsheth reviewed Aug 3, 2023
View reviewed changes
test/utils.js Outdated Show resolved Hide resolved
milapsheth
milapsheth reviewed Aug 3, 2023
View reviewed changes
test/utils.js Outdated Show resolved Hide resolved
@milapsheth milapsheth enabled auto-merge (squash) August 3, 2023 19:24
@milapsheth milapsheth merged commit 519a1b9 into main Aug 3, 2023
3 checks passed
@milapsheth milapsheth deleted the fix/governance-udpate branch August 3, 2023 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milapsheth milapsheth milapsheth approved these changes

@deanamiel deanamiel deanamiel approved these changes

@fish-sammy fish-sammy Awaiting requested review from fish-sammy

@Foivos Foivos Awaiting requested review from Foivos

Assignees

@re1ro re1ro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@re1ro @milapsheth @deanamiel