Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(MultisigBase): signers and voting getters #214

Merged
merged 3 commits into from
Jul 11, 2023
Merged

feat(MultisigBase): signers and voting getters #214

merged 3 commits into from
Jul 11, 2023

Conversation

re1ro
Copy link
Contributor

@re1ro re1ro commented Jul 11, 2023

  • MultisigBase: signers and voting getters

@re1ro re1ro requested a review from deanamiel July 11, 2023 17:23
@re1ro re1ro self-assigned this Jul 11, 2023
deanamiel
deanamiel approved these changes Jul 11, 2023
View reviewed changes
Copy link
Contributor

@deanamiel deanamiel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added tests, MultisigBase.sol is now at full coverage

@milapsheth milapsheth merged commit 48835f7 into main Jul 11, 2023
3 checks passed
@milapsheth milapsheth deleted the feat/multisig-getters branch July 11, 2023 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@milapsheth milapsheth milapsheth approved these changes

@deanamiel deanamiel deanamiel approved these changes

@fish-sammy fish-sammy Awaiting requested review from fish-sammy

@Foivos Foivos Awaiting requested review from Foivos

Assignees

@re1ro re1ro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@re1ro @milapsheth @deanamiel