Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Governance): new module based on TimeLock #196

Merged
merged 15 commits into from
Jun 27, 2023
Merged

feat(Governance): new module based on TimeLock #196

merged 15 commits into from
Jun 27, 2023

Conversation

re1ro
Copy link
Contributor

@re1ro re1ro commented Jun 20, 2023 •
edited
Loading

@re1ro re1ro requested a review from deanamiel June 20, 2023 17:38
@re1ro re1ro requested a review from fish-sammy as a code owner June 20, 2023 17:38
@re1ro re1ro self-assigned this Jun 20, 2023
@re1ro re1ro mentioned this pull request Jun 20, 2023
Merged
2 tasks
@re1ro re1ro requested a review from sergeynog June 20, 2023 17:49
milapsheth
milapsheth reviewed Jun 23, 2023
View reviewed changes
contracts/interfaces/IAxelarGovernance.sol Outdated Show resolved Hide resolved
contracts/governance/AxelarGovernance.sol Outdated Show resolved Hide resolved
contracts/interfaces/IAxelarGovernance.sol Outdated Show resolved Hide resolved
contracts/governance/AxelarGovernance.sol Outdated Show resolved Hide resolved
milapsheth
milapsheth reviewed Jun 27, 2023
View reviewed changes
contracts/interfaces/IInterchainGovernance.sol Outdated Show resolved Hide resolved
contracts/governance/InterchainGovernance.sol Outdated Show resolved Hide resolved
contracts/governance/InterchainGovernance.sol Outdated Show resolved Hide resolved
contracts/governance/InterchainGovernance.sol Show resolved Hide resolved
contracts/governance/InterchainGovernance.sol Outdated Show resolved Hide resolved
contracts/governance/InterchainGovernance.sol Outdated Show resolved Hide resolved
contracts/interfaces/IInterchainGovernance.sol Outdated Show resolved Hide resolved
contracts/interfaces/IInterchainGovernance.sol Outdated Show resolved Hide resolved
.solcover.js Outdated Show resolved Hide resolved
contracts/test/TestInterchainGovernance.sol Show resolved Hide resolved
Dean Amiel and others added 5 commits June 27, 2023 14:21
updated natspec
23037da
@re1ro @milapsheth
Update contracts/governance/InterchainGovernance.sol
4cb33bc 
Co-authored-by: Milap Sheth <milap@axelar.network>
@re1ro @milapsheth
Update contracts/governance/InterchainGovernance.sol
d6fb61d 
Co-authored-by: Milap Sheth <milap@axelar.network>
@re1ro @milapsheth
Update .solcover.js
8f2c7e7 
Co-authored-by: Milap Sheth <milap@axelar.network>
@re1ro
fix(Governance): handling native value
39a1ab5
@re1ro re1ro requested a review from milapsheth June 27, 2023 22:16
milapsheth
milapsheth approved these changes Jun 27, 2023
View reviewed changes
contracts/governance/InterchainGovernance.sol Outdated Show resolved Hide resolved
contracts/governance/InterchainGovernance.sol Show resolved Hide resolved
contracts/interfaces/IInterchainGovernance.sol Outdated Show resolved Hide resolved
@re1ro re1ro merged commit ff60e05 into main Jun 27, 2023
3 checks passed
@re1ro re1ro deleted the feat/governance-module branch June 27, 2023 22:54
@re1ro re1ro mentioned this pull request Jun 28, 2023
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fish-sammy fish-sammy fish-sammy left review comments

@milapsheth milapsheth milapsheth approved these changes

@deanamiel deanamiel deanamiel approved these changes

@Foivos Foivos Awaiting requested review from Foivos

@sergeynog sergeynog Awaiting requested review from sergeynog

Assignees

@re1ro re1ro

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@re1ro @fish-sammy @milapsheth @deanamiel