-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(README): updating dependencies and build instructions #108
Conversation
package.json
Outdated
@@ -43,6 +43,6 @@ | |||
"solidity-coverage": "^0.7.17" | |||
}, | |||
"engines": { | |||
"node": ">=14" | |||
"node": ">=16.15.1 <17" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using the latest v16 release seems too restrictive since most people don't update for every patch?
"node": ">=16.15.1 <17" | |
"node": ">=16 <17" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agree.
Maybe bump up the dev dependencies too? |
@milapsheth dev deps are bumped in the lock file, but I will also bump them in the package.json for consistency |
Updating README to reflect latest hardhat changes