feat/freeze removal #105
Merged
feat/freeze removal #105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fish-sammy
force-pushed
the
feat/freeze-removal
branch
from
af732a5
to
2363bac
Compare
milapsheth
reviewed
Jun 1, 2022
| bytes32 internal constant PREFIX_COMMAND_EXECUTED = keccak256('command-executed'); | ||
| bytes32 internal constant PREFIX_TOKEN_ADDRESS = keccak256('token-address'); | ||
| bytes32 internal constant PREFIX_TOKEN_TYPE = keccak256('token-type'); | ||
| bytes32 internal constant PREFIX_TOKEN_FROZEN = keccak256('token-frozen'); |
There was a problem hiding this comment.
Can we keep the prefixes either commented out or some other way so we don't have prefix collisions in the future?
There was a problem hiding this comment.
I think commenting them out is a good idea in general, but in this case none of the storage slots are used as we don't have any tokens frozen
There was a problem hiding this comment.
We could potentially have some frozen at the time of deployment, so it's usually safest to avoid making assumptions on the future state.
re1ro
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.