Skip to content

Commit

Permalink
[controller] Properly retry failures
Browse files Browse the repository at this point in the history
The `retryModificationFailures` parameter was never used when initializing the modify controller. As a result, modification failures were not retried until the PVC was re-processed (because the driver restarted or the PVC re-added to the cache)
  • Loading branch information
Fricounet committed Nov 8, 2024
1 parent 25bb74d commit f52ce50
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions pkg/controller/controller.go
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,7 @@ func NewModifyController(
claims: pvcInformer.Informer().GetStore(),
eventRecorder: eventRecorder,
modificationInProgress: make(map[string]struct{}),
retryFailures: retryModificationFailures,
}

pvcInformer.Informer().AddEventHandlerWithResyncPeriod(cache.ResourceEventHandlerFuncs{
Expand Down

0 comments on commit f52ce50

Please sign in to comment.