Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Support other image formats for architecture diagrams and dataflow diagrams. Close #84 #88

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

jessieweiyi
Copy link
Contributor

Issue #, if available:

#84

Description of changes:

Allow all image formats (image/*) upload for architecture diagrams and dataflow diagrams. For 'image/png', 'image/gif', or 'image/jpeg', run the browser-image-compression plugin; for other images, keep the original format. The total number bytes of the resulted base64 encoded image is checked to ensure it is less than 1MB.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jessieweiyi jessieweiyi requested a review from dboyd13 February 23, 2024 01:55
Copy link
Contributor

@dboyd13 dboyd13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@dboyd13 dboyd13 merged commit bc20efc into main Feb 23, 2024
2 checks passed
@dboyd13 dboyd13 deleted the feat/svg branch February 23, 2024 04:10
Copy link

🎉 This PR is included in version 1.0.34 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants