Fix #150: dateRangeChange incorrectly called #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't forget to squash all the commits into 1! :D |
boweihan
reviewed
Aug 5, 2022
packages/synchro-charts/src/components/charts/sc-webgl-base-chart/sc-webgl-base-chart.tsx
Show resolved
Hide resolved
jmbuss
requested changes
Aug 5, 2022
packages/synchro-charts/src/components/charts/sc-webgl-base-chart/sc-webgl-base-chart.tsx
Show resolved
Hide resolved
packages/synchro-charts/src/components/charts/sc-webgl-base-chart/utils.ts
Outdated
Show resolved
Hide resolved
block event emission when viewport changes due to a live mode update fix linting issues add rest property types to updateViewPort fix #150 dateRangeChange called in live mode
tjuranek
force-pushed
the
bug-fix-150-dateRangeChange
branch
from
b1e47a3 to
797b043
Compare
jmbuss
approved these changes
Aug 9, 2022
diehbria
reviewed
Aug 9, 2022
| manager.updateViewPort({ start: newStart, end: newEnd, duration }); | ||
|
|
||
| // Have manager update its own viewport, preventing 'dateRangeChange' events when in live mode | ||
| const isInLiveMode = Boolean(duration); |
There was a problem hiding this comment.
Can we just say duration != duration (a common pattern in this code base) rather than relying on the fact that Boolean(undefined) === 0
Another thought: what does duration: 0 imply? Would it possibly make sense to be in live mode, but only for a single instance in time? With this logic, it would detect as not being in live mode
| jest.advanceTimersByTime(secondsElapsed * SECOND_IN_MS); | ||
| expect(manager.updateViewPort).toBeCalledWith( | ||
| expect.objectContaining({ | ||
| shouldBlockDateRangeChangedEvent: true, |
There was a problem hiding this comment.
what about the situation where it shouldn't be blocked?
diehbria
pushed a commit
that referenced
this pull request
Sep 29, 2022
add flag for blocking dateRangeChanged event when in live mode block event emission when viewport changes due to a live mode update fix linting issues add rest property types to updateViewPort Co-authored-by: Thomas Juranek <thjurane@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fixes #150.
When in live mode, the viewportHandler tick cycle was passing the updated viewport back to the rendered chart. The logic was set to emit the
dateRangeChangeevent any time the viewport changed. When in live mode this isn't the desired behavior so a flag was added to be able to check for that and block the event from being emitted.Tests
[Include a link to the passing GitHub action running the test suite here.]
Legal
This project is available under the Apache 2.0 License.