Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix incompatibilities caused by the latest cargo fix #778

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

nabetti1720
Copy link
Contributor

Description of changes

After applying the latest rust toolchain, we found new incompatibilities and have fixed them.

% rustup update          
info: syncing channel updates for 'stable-aarch64-apple-darwin'
info: syncing channel updates for 'nightly-aarch64-apple-darwin'
info: checking for self-update

   stable-aarch64-apple-darwin unchanged - rustc 1.84.0 (9fc6b4312 2025-01-07)
  nightly-aarch64-apple-darwin unchanged - rustc 1.86.0-nightly (824759493 2025-01-09)

Checklist

  • Created unit tests in tests/unit and/or in Rust for my feature if needed
  • Ran make fix to format JS and apply Clippy auto fixes
  • Made sure my code didn't add any additional warnings: make check
  • Added relevant type info in types/ directory
  • Updated documentation if needed (API.md/README.md/Other)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@richarddavison
Copy link
Contributor

@nabetti1720 thanks, i added these in webcrypto PR but it’s better to have them isolated here

@richarddavison richarddavison merged commit 7e6c451 into awslabs:main Jan 10, 2025
11 checks passed
@nabetti1720 nabetti1720 deleted the fix/cargo-fix branch January 10, 2025 23:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants