Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update React DOM to use edge #776

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

ShivamJoker
Copy link
Contributor

Issue # (if available)

Closes #769

Description of changes

async hooks won't be supported and are discouraged, the edge version of React DOM doesn't use async hooks.

Checklist

  • Created unit tests in tests/unit and/or in Rust for my feature if needed
  • Ran make fix to format JS and apply Clippy auto fixes
  • Made sure my code didn't add any additional warnings: make check
  • Added relevant type info in types/ directory
  • Updated documentation if needed (API.md/README.md/Other)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

async hooks won't be supported and are discouraged, the edge version of React DOM doesn't use async hooks.
Copy link
Contributor

@richarddavison richarddavison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM

@richarddavison richarddavison merged commit 47baedc into awslabs:main Jan 9, 2025
11 checks passed
@ShivamJoker ShivamJoker deleted the fix/react-dom-19 branch January 9, 2025 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

React DOM 19 breaks the rendering due to async_hooks
2 participants