Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iot app kit core v2 #9

Closed
wants to merge 1 commit into from
Closed

Iot app kit core v2 #9

wants to merge 1 commit into from

Conversation

diehbria
Copy link
Contributor

@diehbria diehbria commented Nov 23, 2021

Overview

The major work in this PR will be the error handling, restructuring the core data module, the subscription store, and the request handler.

With this PR, errors will no longer re-request every 5 seconds for all properties (no longer spamming the backend w/ 403s), and subscribers to data-module will only have messages emitted to them when the information being emitted is different than previously.

  • Prevent data streams with associated errors from re-requesting over
    and over
  • Refactor subscription store to utilize RXJS to broadcast subscription
    updates to subscribers
  • Update types on @iot-app-kit/components to be any query
  • Remove unused dependency on redux-thunk
  • Up required code coverage targets
  • apply root level yarn run fix

Legal

This project is available under the Apache 2.0 License.

@diehbria diehbria force-pushed the iot-app-kit-core-v2 branch 2 times, most recently from c96c5d0 to a1be44e Compare November 23, 2021 17:45
NorbertNader
NorbertNader previously approved these changes Nov 23, 2021
 * Prevent data streams with associated errors from re-requesting over
  and over
 * Refactor subscription store to utilize RXJS to broadcast subscription
  updates to subscribers
 * Update types on @iot-app-kit/components to be any query
 * Remove unused dependency on redux-thunk
 * Up required code coverage targets
 * run linting on test
@diehbria diehbria force-pushed the iot-app-kit-core-v2 branch from 53dd3f9 to 85f9567 Compare November 23, 2021 23:30
@diehbria diehbria marked this pull request as draft November 29, 2021 16:32
@diehbria diehbria closed this Nov 29, 2021
@diehbria diehbria deleted the iot-app-kit-core-v2 branch May 5, 2022 16:27
sheilaXu pushed a commit that referenced this pull request Sep 23, 2022
* Release 1.2.1 (#85)

* fix: unsubrscribe data provider on component updates

* Release 1.2.1

Co-authored-by: Norbert Nader <nnader@amazon.com>

* fix: resolves #83 (#87)

* fix: resolves #83

* Update index.ts

Co-authored-by: Norbert Nader <nnader@amazon.com>

* feat: improve documentation (#90)

* Run tests on pull request (#91)

* Update reference to code name (#86)

AWS-UI internal code name is mentioned in the readme.

Co-authored-by: Norbert Nader <Norbert.Nader@gmail.com>

* feat: update synchro charts to 3.1.0, update docs (#92)

* feat: Improve documentation formatting (#93)

* feat: Improve resource explorer docs (#95)

* Update README.md (#94)

* feat: support fetchMostRecentBeforeStart (#79)

* Update documentation & make react-components easier to use (#98)

* Utilize lock file in CI (#99)

* build(deps): bump async from 2.6.3 to 2.6.4 (#100)

Bumps [async](https://github.com/caolan/async) from 2.6.3 to 2.6.4.
- [Release notes](https://github.com/caolan/async/releases)
- [Changelog](https://github.com/caolan/async/blob/v2.6.4/CHANGELOG.md)
- [Commits](caolan/async@v2.6.3...v2.6.4)

---
updated-dependencies:
- dependency-name: async
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: support auto-assigning colors for certain components (#96)

* feat: support auto-assigning colors for certain components

* Update package.json

* Update cypress to v9, added stricted linting, fixed linting warnings and errors (#104)

* Add stylelint and enforce via global package.json (#106)

* use most recent synchro-charts version, 4.0.1 (#111)

* build(deps): bump eventsource from 1.1.0 to 1.1.1 (#116)

Bumps [eventsource](https://github.com/EventSource/eventsource) from 1.1.0 to 1.1.1.
- [Release notes](https://github.com/EventSource/eventsource/releases)
- [Changelog](https://github.com/EventSource/eventsource/blob/master/HISTORY.md)
- [Commits](EventSource/eventsource@v1.1.0...v1.1.1)

---
updated-dependencies:
- dependency-name: eventsource
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat: expand children in resource explorer (#115)

* feat: expand children in resource explorer

* fix typo

* Fix asset module cache

* Add logic for fetching hierarchies

* Add tests

* Improve insert

* Fix linting

Co-authored-by: Norbert Nader <nnader@amazon.com>

* Update README.md (#121)

Fix test runner status badge

* Bump minor version (#120)

Co-authored-by: Norbert Nader <Norbert.Nader@gmail.com>
Co-authored-by: Norbert Nader <nnader@amazon.com>
Co-authored-by: db <77755322+diehbria@users.noreply.github.com>
Co-authored-by: Mitchell Lee <mitch@evildev.net>
Co-authored-by: Bowei Han <boweih@amazon.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Xinyi <xinyxu@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants