feat: error handling/data-module core #7
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Prevent data streams with associated errors from re-requesting over and over * Refactor subscription store to utilize RXJS to broadcast subscription updates to subscribers * Update types on @iot-app-kit/components to be any query * Remove unused dependency on redux-thunk * Up required code coverage targets
diehbria
requested review from
fpauer,
NorbertNader,
boweihan and
gareth-amazon
NorbertNader
previously approved these changes
Nov 22, 2021
|
This is awesome work! Just had some clarifying questions. |
NorbertNader
approved these changes
Nov 22, 2021
sheilaXu
pushed a commit
that referenced
this pull request
Sep 23, 2022
* Release 1.2.1 (#85) * fix: unsubrscribe data provider on component updates * Release 1.2.1 Co-authored-by: Norbert Nader <nnader@amazon.com> * fix: resolves #83 (#87) * fix: resolves #83 * Update index.ts Co-authored-by: Norbert Nader <nnader@amazon.com> * feat: improve documentation (#90) * Run tests on pull request (#91) * Update reference to code name (#86) AWS-UI internal code name is mentioned in the readme. Co-authored-by: Norbert Nader <Norbert.Nader@gmail.com> * feat: update synchro charts to 3.1.0, update docs (#92) * feat: Improve documentation formatting (#93) * feat: Improve resource explorer docs (#95) * Update README.md (#94) * feat: support fetchMostRecentBeforeStart (#79) Co-authored-by: Norbert Nader <Norbert.Nader@gmail.com> Co-authored-by: Norbert Nader <nnader@amazon.com> Co-authored-by: db <77755322+diehbria@users.noreply.github.com> Co-authored-by: Mitchell Lee <mitch@evildev.net> Co-authored-by: Bowei Han <boweih@amazon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
The major work in this PR will be the error handling, restructuring the core data module, the subscription store, and the request handler.
With this PR, errors will no longer re-request every 5 seconds for all properties (no longer spamming the backend w/ 403s), and subscribers to data-module will only have messages emitted to them when the information being emitted is different than previously.
and over
updates to subscribers
Testing:
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.