chore(dial): port over DialBase from SynchroCharts #590
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NorbertNader
approved these changes
Feb 16, 2023
jmbuss
approved these changes
Feb 16, 2023
| }); | ||
| const { viewport } = useViewport(); | ||
|
|
||
| const utilizedViewport = passedInViewport || viewport; // explicitly passed in viewport overrides viewport group |
There was a problem hiding this comment.
Should an override be a part of the viewport hook? I imagine every component is going to have this line?
There was a problem hiding this comment.
I'm not so sure, while your right it'll be a common pattern, it is possibly more intuitive for people to just handle this themselves then have to understand that a viewport passed into useViewport overrides the viewport and makes it so use viewport does nothing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Ports over dial component from synchrocharts. Also refactors to remove calls to calculate bounding boxes and eliminate a lot of state mutations, in preference for a simpler, more straightforward implementation
Follow up PR will be made which will add icons, tests, etc. This is the first iteration, and does not expose the dial component publicly.
Legal
This project is available under the Apache 2.0 License.