feat: Add support for update within subscribeToTimeSeriesData #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diehbria
requested review from
boweihan,
gareth-amazon,
fpauer and
NorbertNader
boweihan
reviewed
Feb 10, 2022
|
|
||
| return { | ||
| unsubscribe: () => { | ||
| unsubscribe(); | ||
| assetModuleSession.close(); |
There was a problem hiding this comment.
I think a session =/= a subscription. I think a session should be able to handle multiple subscriptions. subscribeTo... should return unsubscribe but it shouldn't close the sessions.
diehbria
force-pushed
the
coord-update
branch
from
7563ea4 to
be88cff
Compare
sheilaXu
pushed a commit
that referenced
this pull request
Sep 23, 2022
Co-authored-by: Mitchell Lee <mitchlee@amazon.com>
TheEvilDev
pushed a commit
that referenced
this pull request
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
updatefunctionality within thesubscribeToTimeSeriesDataunsubscribefunctionalityLegal
This project is available under the Apache 2.0 License.