Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: improve clean script #43

Merged
merged 2 commits into from
Jan 31, 2022
Merged

feat: improve clean script #43

merged 2 commits into from
Jan 31, 2022

Conversation

NorbertNader
Copy link
Contributor

@NorbertNader NorbertNader commented Jan 29, 2022 •
edited
Loading

Overview

Improve clean script which was not very useful.
The new script will remove all directories generated at build time.
Under the hood this runs git clean which removes all files and directories from .gitignore with the exception of IDE configurations and creds.json file.

example output:

yarn run v1.22.11
$ git clean -dxf -e /.idea -e /.vscode -e creds.json
Removing node_modules/
Removing packages/components/dist/
Removing packages/components/loader/
Removing packages/components/node_modules/
Removing packages/components/www/
Removing packages/core/dist/
Removing packages/core/node_modules/
Removing packages/core/www/
Removing packages/node_modules/
Removing packages/related-table/dist/
Removing packages/related-table/node_modules/
Removing yarn.lock

Tests

none

Legal

This project is available under the Apache 2.0 License.

@NorbertNader NorbertNader added the enhancement New feature or request label Jan 29, 2022
@NorbertNader NorbertNader self-assigned this Jan 29, 2022
@NorbertNader NorbertNader force-pushed the clean-all-script branch 2 times, most recently from 53831c0 to 4811bdf Compare January 29, 2022 06:44
@NorbertNader NorbertNader changed the title feat: add clean:all script feat: improve clean script Jan 29, 2022
boweihan
boweihan approved these changes Jan 31, 2022
View reviewed changes
package.json
@@ -14,7 +14,7 @@
"scripts": {
"start": "cd packages/components && yarn run start",
"build": "lerna run build --stream",
"clean": "lerna run clean --concurrency 4",
"clean": "git clean -dxf -e /.idea -e /.vscode -e creds.json",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet!

@NorbertNader NorbertNader merged commit 4501670 into main Jan 31, 2022
@NorbertNader NorbertNader deleted the clean-all-script branch February 22, 2022 17:58
sheilaXu pushed a commit that referenced this pull request Sep 23, 2022
@TheEvilDev
Adding back package-locks to fix pipeline build (#43)
62e13e3 
Co-authored-by: Mitchell Lee <mitchlee@amazon.com>
@github-actions github-actions bot mentioned this pull request Oct 26, 2022
Closed
TheEvilDev pushed a commit that referenced this pull request Nov 2, 2022
@NorbertNader
feat: improve clean script (#43)
38f5f84 
Co-authored-by: Norbert Nader <nnader@amazon.com>
This was referenced Nov 2, 2022
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boweihan boweihan boweihan approved these changes

@fpauer fpauer Awaiting requested review from fpauer

@diehbria diehbria Awaiting requested review from diehbria

@gareth-amazon gareth-amazon Awaiting requested review from gareth-amazon

Assignees

@NorbertNader NorbertNader

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@NorbertNader @boweihan