Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support cacheSettings at a query level #41

Merged
merged 1 commit into from
Jan 26, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 48 additions & 0 deletions packages/core/src/data-module/IotAppKitDataModule.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -808,6 +808,54 @@ describe('caching', () => {
});
});

it('overrides module-level cache TTL if query-level cache TTL is provided', async () => {
const customCacheSettings = {
ttlDurationMapping: {
[MINUTE_IN_MS]: 0,
[5 * MINUTE_IN_MS]: 30 * SECOND_IN_MS,
},
};

const dataModule = new IotAppKitDataModule({ cacheSettings: customCacheSettings });
const dataSource = createMockSiteWiseDataSource([DATA_STREAM]);
dataModule.registerDataSource(dataSource);

const END = new Date();
const START = new Date(END.getTime() - HOUR_IN_MS);

const dataStreamCallback = jest.fn();
dataModule.subscribeToDataStreams(
{
queries: [
{
...DATA_STREAM_QUERY,
cacheSettings: {
ttlDurationMapping: {
[MINUTE_IN_MS]: 0,
[10 * MINUTE_IN_MS]: 30 * SECOND_IN_MS,
},
},
},
],
request: { viewport: { start: START, end: END }, settings: { refreshRate: MINUTE_IN_MS } },
},
dataStreamCallback
);

(dataSource.initiateRequest as Mock).mockClear();
jest.advanceTimersByTime(MINUTE_IN_MS);

expect(dataSource.initiateRequest).toBeCalledWith(expect.any(Object), [
{
id: DATA_STREAM_INFO.id,
resolution: DATA_STREAM_INFO.resolution,
// 1 minute time advancement invalidates 10 minutes of cache with query-level mapping, which is 9 minutes from END_1
start: new Date(END.getTime() - 9 * MINUTE_IN_MS),
end: END,
},
]);
});

describe('request scheduler', () => {
it('periodically requests duration based queries', async () => {
const dataModule = new IotAppKitDataModule();
Expand Down
4 changes: 2 additions & 2 deletions packages/core/src/data-module/IotAppKitDataModule.ts
Original file line number Diff line number Diff line change
Expand Up @@ -100,14 +100,14 @@ export class IotAppKitDataModule implements DataModule {
);

const requests = requiredStreams
.map(({ resolution, id }) => {
.map(({ resolution, id, cacheSettings }) => {
const dateRanges = getDateRangesToRequest({
store: this.dataCache.getState(),
start: adjustedStart,
end: adjustedEnd,
resolution,
dataStreamId: id,
cacheSettings: this.cacheSettings,
cacheSettings: { ...this.cacheSettings, ...cacheSettings },
});

return {
Expand Down
23 changes: 23 additions & 0 deletions packages/core/src/data-module/data-cache/caching/caching.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ import {
EMPTY_CACHE,
getDateRangesToRequest,
unexpiredCacheIntervals,
maxCacheDuration,
} from './caching';
import { DEFAULT_CACHE_SETTINGS } from '../../IotAppKitDataModule';
import { HOUR_IN_MS, MINUTE_IN_MS, SECOND_IN_MS } from '../../../common/time';
Expand Down Expand Up @@ -1210,3 +1211,25 @@ describe('checkCacheForRecentPoint', () => {
expect(presentInCache).toBeFalse();
});
});

describe('maxCacheDuration', () => {
it('returns the maximum cache TTL duration', () => {
expect(
maxCacheDuration({
ttlDurationMapping: {
[1.2 * MINUTE_IN_MS]: 0,
[3 * MINUTE_IN_MS]: 30 * SECOND_IN_MS,
[20 * MINUTE_IN_MS]: 5 * MINUTE_IN_MS,
},
})
).toBe(20 * MINUTE_IN_MS);
});

it('handles empty mappings', () => {
expect(
maxCacheDuration({
ttlDurationMapping: {},
})
).toBe(0);
});
});
11 changes: 11 additions & 0 deletions packages/core/src/data-module/data-cache/caching/caching.ts
Original file line number Diff line number Diff line change
Expand Up @@ -204,3 +204,14 @@ export const validateRequestConfig = (requestConfig: TimeSeriesDataRequestSettin

return false;
};

// Returns the maximum duration for possible uncached data for given CacheSettings
export const maxCacheDuration = (cacheSettings: CacheSettings) => {
const ttlDurations = Object.keys(cacheSettings.ttlDurationMapping).map((key) => Number(key));

if (ttlDurations.length === 0) {
return 0;
}

return Math.max(...ttlDurations);
};
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,9 @@ export default class DataSourceStore {
request: TimeSeriesDataRequest;
}): RequestInformation[] => {
const dataSource = this.getDataSource(query.source);
return dataSource.getRequestsFromQuery({ query, request });
return dataSource
.getRequestsFromQuery({ query, request })
.map((request) => ({ ...request, cacheSettings: query.cacheSettings }));
};

public initiateRequest = <Query extends DataStreamQuery>(
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { CacheSettings } from '../data-cache/types';
import DataSourceStore from '../data-source-store/dataSourceStore';
import RequestScheduler from '../request-scheduler/requestScheduler';
import { viewportEndDate } from '../../common/viewport';
import { maxCacheDuration } from '../data-cache/caching/caching';

/**
* Subscription store
Expand Down Expand Up @@ -55,7 +56,11 @@ export default class SubscriptionStore {
refreshRate: subscription.request.settings?.refreshRate,
refreshExpiration:
viewportEndDate(subscription.request.viewport).getTime() +
Math.max(...Object.keys(this.cacheSettings.ttlDurationMapping).map((key) => Number(key))),
Math.max(
...subscription.queries.map((query) =>
maxCacheDuration({ ...this.cacheSettings, ...query.cacheSettings })
)
),
});
}

Expand Down
9 changes: 8 additions & 1 deletion packages/core/src/data-module/types.d.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,14 @@ import {
ListAssociatedAssetsCommandOutput,
} from '@aws-sdk/client-iotsitewise';
import { RefId } from '../data-sources/site-wise/types';
import { CacheSettings } from './data-cache/types';

export type RequestInformation = { id: DataStreamId; resolution: Resolution; refId?: RefId };
export type RequestInformation = {
id: DataStreamId;
resolution: Resolution;
refId?: RefId;
cacheSettings?: CacheSettings;
};
export type RequestInformationAndRange = RequestInformation & { start: Date; end: Date };

export type DataSourceName = string;
Expand Down Expand Up @@ -55,6 +61,7 @@ export type DataModuleSubscription<Query extends DataStreamQuery> = {

export type DataStreamQuery = {
source: DataSourceName;
cacheSettings?: CacheSettings;
};

export type AnyDataStreamQuery = DataStreamQuery & any;
Expand Down
2 changes: 2 additions & 0 deletions packages/core/src/data-sources/site-wise/types.d.ts
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { CacheSettings } from '../../data-module/data-cache/types';
import { DataStreamQuery, SubscriptionUpdate } from '../../data-module/types.d';

/**
Expand All @@ -17,6 +18,7 @@ export type PropertyQuery = {
propertyId: string;
refId?: RefId;
resolution?: string;
cacheSettings?: CacheSettings;
};

export type AssetQuery = {
Expand Down