Prevent Sub-Models from being moved without a feature flag #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheEvilDev
previously approved these changes
Nov 9, 2022
| [selectedSceneNode], | ||
| ); | ||
|
|
||
| const showForSubModel = !isSubModelComponent || subModelMovementEnabled; |
There was a problem hiding this comment.
Would probably name this something like "transformVisible".
There was a problem hiding this comment.
I'll do it now so I don't forget
TheEvilDev
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Due to issues with Multiple World spaces and/or coordinates for Sub Models preventing the ability to adjust the sub-model position ensures that child objects will continue to work. We hide the ability to edit a Sub-model's position behind a new feature flag
SubModelMovementLegal
This project is available under the Apache 2.0 License.