feat: Onboard cypress with component test runner #34
Conversation
* Backfill on missing gestures tests. Was not able to get panning to work since triggering mousedown and mousemove are not propagating the event to the gesture handler.
NorbertNader
requested review from
fpauer,
boweihan,
diehbria and
gareth-amazon
| @@ -16,7 +16,31 @@ jobs: | |||
| run: | | |||
| yarn install | |||
| yarn build | |||
| ./packages/components/node_modules/cypress/bin/cypress install | |||
There was a problem hiding this comment.
known issue cypress-io/github-action#474
The tests are not picking up the styles because I am not importing the synchro-charts css anywhere like we are in testing-ground As for the freezing tests, I could not find an open issue for this. I might have to open one myself but before I do that I will have to figure out what is causing this. The chart axis actually loads but the chart visualization does not. |
is there any solution to adding the styles so the tests reflect what the app kit would look like for users? |
Ofc we can! This assumes though that the customer will import the styles. I guess it is up to us if we want to test it raw or with the styles we recommend. |
* Add SceneComposerInternal and move root level files to sub folders * update coverage Co-authored-by: Xinyi Xu <xinyxu@amazon.com>
* feat: Onboard cypress with component test runner * Backfill on missing gestures tests. Was not able to get panning to work since triggering mousedown and mousemove are not propagating the event to the gesture handler. * Add styles to rendered charts Co-authored-by: Norbert Nader <nnader@amazon.com>
Overview
Onboard cypress with component test runner
Backfill on missing gestures tests. Was not able to get panning to work since triggering
mousedownandmousemoveare not propagating the event to the gesture handler.Another gotcha I ran into is that
cypress run-ctfreezes with multiple tests in one file hence why I run zoom in and zoom out in one tests.Created a branch to test failures. As expected, the workflow failed https://github.com/awslabs/iot-app-kit/runs/4821245292?check_suite_focus=true
Tests
Added integration tests
Legal
This project is available under the Apache 2.0 License.