Catch to prevent and debug remove from parent race condition #339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwills-jdubs
force-pushed
the
remove-from-parent-bug
branch
from
5054705 to
1dfe4fe
Compare
jwills-jdubs
force-pushed
the
remove-from-parent-bug
branch
from
1dfe4fe to
692ea3e
Compare
|
This pull request introduces 1 alert when merging 692ea3e into 9a2c991 - view on LGTM.com new alerts:
|
mumanity
approved these changes
Nov 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
There is a race condition that requires some error handling. We have checks for existence but given the issue might not be that the object is falsey we perform a catch to provide further debug information
Legal
This project is available under the Apache 2.0 License.