fix: 3rd-party imports during build #3097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Currently, build artifacts are replacing import statements on third-party npm modules with relative paths due to an error in the vite/rollup package externalization config.
This change fixes the change, preventing the alteration of import statements externalized node_modules, as expected.
With this configuration change, package dependencies which are not explicitly included in the package.json will now be bundled by vite and included in a node_modules dir in the package artifacts. To prevent this from occurring, as we do not want to include any dependency code in our dist, the dependencies were explicitly added to each consuming package.json. This allows the plugin handling the externalization to recognize it should ignore the import.
Legal
This project is available under the Apache 2.0 License.