Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: clean script and dependency task management #3094

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

tracy-french
Copy link
Contributor

@tracy-french tracy-french commented Dec 11, 2024

Overview

This change includes:

  • Improvements on clean scripts.
  • Optimization of GH actions to split turbo tasks (i.e., link, tests, build/pack) into their own steps. Improves speed of GH actions and prevents turbo pack's dependency on clean from running and breaking GH actions relying on caches. Additionally, the dependencies on the repo task have been removed to allow for immediate running of all validation actions. 100% cache hit on the GH action now takes ~2 minutes to complete.
  • Update turbo.json to enable turbo cache busting when dependency has changed, yet no dependent task needs to be run. This is necessary to get non-persistent turbo tasks to recognize a dependencies source code has changed (for live development - no builds) and invalidate the package's caches for tasks like unit testing and linting. This is what all the manual input mapping code is in turbo.json.
  • Fix for flaky resource explorer drop-down unit tests which are regularly failing in the GH actions, requiring react-component actions to be re-run.

Legal

This project is available under the Apache 2.0 License.

@tracy-french tracy-french force-pushed the fix-scripts-and-tasks branch 5 times, most recently from 311e84f to 35dd37f Compare December 11, 2024 19:21
@tracy-french tracy-french marked this pull request as ready for review December 11, 2024 19:37
@tracy-french tracy-french merged commit 79849bc into rc Dec 11, 2024
44 checks passed
@tracy-french tracy-french deleted the fix-scripts-and-tasks branch December 11, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants