Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix time series data hook reactivity #3069

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

jmbuss
Copy link
Contributor

@jmbuss jmbuss commented Nov 25, 2024

Overview

2 bugfixes:

  1. There is a bug in the handling of time series data module session subscriptions where it is possible for a callback to try to unsubscribe to a session that is already unregistered. This is in the handler which unsubscribes if the client session expires. The fix checks that the subscription is still valid and unsubscribes only if it hasn't been already handled. The likely scenario for this happening is if a user leaves there dashboard open over night and re-focuses the tab so that the polling starts again.
  2. There is a bug where, in the dashboard, if you add multiple datastreams to a chart with an alarm, removing the datastreams before removing the alarm will result in the last datastream to be removed staying in the chart. This is a reactivity bug in use-time-series-data. To fix this, we clear the datastreams state whenever the queries provided to use time series data changes.

Legal

This project is available under the Apache 2.0 License.

Copy link
Contributor

@chejimmy chejimmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jmbuss jmbuss merged commit 289c135 into rc Nov 26, 2024
21 checks passed
@jmbuss jmbuss deleted the fix/time-series-data-reactivity branch November 26, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants