fix: network perfomance issue fixes #2349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove CSV download feature to remove extra calls to useTimeSeriesData.
The download button makes use of useTimeSeriesData which will make calls as the viewport updates instead of only requesting when the user clicks it.
Remove fetchMostRecentBeforeStart for performance issues.
fetchMostRecentBeforeStart ensures that if there exists a point before the current viewport that the leading line is drawn. Removing this leaves an edgecase that if this point exists, that no leading line or an incorrect leading line will be drawn. Removing this halves the number of network requests made while panning, so we are choosing to do this for performance issues.
Legal
This project is available under the Apache 2.0 License.