Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(composer): trigger onSceneLoaded after dynamic scene is loaded #2344

Merged
merged 1 commit into from
Dec 6, 2023

Conversation

sheilaXu
Copy link
Contributor

@sheilaXu sheilaXu commented Dec 6, 2023

Overview

trigger onSceneLoaded after dynamic scene is loaded

Verifying Changes

Tested with static scene, dynamic scene, static matterport scene and dynamic matterport scene, onSceneLoaded is triggered once after nodes and matterport are ready

Scene Composer

For scene-composer package changes specifically, you can preview the component in the published storybook artifact. To do this, wait for the Publish Storybook action to complete below.

  • Click on the workflow details
  • Select the Summary item on the left
  • Download the zip file

To run the storybook build locally, you need a local static web server:

npm install -g httpserver
cd <Extracted Zip Directory>
httpserver

Then open the website http://localhost:8080 to run the doc site.

Legal

This project is available under the Apache 2.0 License.

@sheilaXu sheilaXu enabled auto-merge (rebase) December 6, 2023 19:05
@sheilaXu sheilaXu merged commit 4c9453a into main Dec 6, 2023
10 checks passed
@sheilaXu sheilaXu deleted the onSceneLoad-fix branch December 6, 2023 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants