feat(react-components): hide/show properties from legend #2208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
mnischay
reviewed
Nov 1, 2023
packages/react-components/src/components/chart/legend/icons.tsx
Outdated
Show resolved
Hide resolved
ssjagad
force-pushed
the
hide-show
branch
4 times, most recently
from
3e70386 to
e5ea40b
Compare
mnischay
reviewed
Nov 2, 2023
packages/react-components/src/components/chart/legend/useChartsLegend.tsx
Outdated
Show resolved
Hide resolved
mnischay
reviewed
Nov 2, 2023
packages/react-components/src/components/chart/store/contextDataStreams.ts
Show resolved
Hide resolved
mnischay
reviewed
Nov 2, 2023
packages/react-components/src/components/chart/store/contextDataStreams.ts
Show resolved
Hide resolved
mnischay
reviewed
Nov 2, 2023
...ges/react-components/src/components/chart/trendCursor/tests/useVisualizedDataStreams.spec.ts
Outdated
Show resolved
Hide resolved
mnischay
previously requested changes
Nov 2, 2023
ssjagad
force-pushed
the
hide-show
branch
4 times, most recently
from
a29b5fe to
67a1484
Compare
mnischay
reviewed
Nov 3, 2023
ssjagad
force-pushed
the
hide-show
branch
2 times, most recently
from
f3e3af0 to
59b4b44
Compare
ssjagad
force-pushed
the
hide-show
branch
4 times, most recently
from
0431ab7 to
62de077
Compare
corteggiano
reviewed
Dec 15, 2023
...react-components/src/components/chart/trendCursor/getTrendCursor/components/markers/index.ts
Outdated
Show resolved
Hide resolved
corteggiano
reviewed
Dec 15, 2023
packages/react-components/src/components/chart/trendCursor/series/useHandleSeries.ts
Outdated
Show resolved
Hide resolved
corteggiano
reviewed
Dec 15, 2023
packages/react-components/src/components/chart/utils/getStyles.ts
Outdated
Show resolved
Hide resolved
corteggiano
reviewed
Dec 15, 2023
packages/react-components/src/components/chart/legend/useChartsLegend.tsx
Outdated
Show resolved
Hide resolved
ssjagad
force-pushed
the
hide-show
branch
5 times, most recently
from
8ad42cb to
8467b65
Compare
corteggiano
reviewed
Dec 26, 2023
corteggiano
reviewed
Dec 26, 2023
| @@ -44,5 +45,5 @@ export const useHandleSeries = ({ | |||
| }; | |||
|
|
|||
| delayedRender({ updateFunction: update }); | |||
| }, [chartRef, series.length, setGraphic]); | |||
| }, [chartRef, seriesString, setGraphic]); | |||
There was a problem hiding this comment.
just tested locally and this change causes TCs to rerender a ton of times if any part of the series changes (color, line style, symbol, y axis)
There was a problem hiding this comment.
could we keep series.length and also do number of series with an opacity of 0?
ssjagad
force-pushed
the
hide-show
branch
2 times, most recently
from
3fce554 to
bd124c6
Compare
corteggiano
approved these changes
Dec 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Allow users to toggle the visibility of a property from within the legend.
Verifying Changes
Screen.Recording.2023-12-13.at.2.08.33.PM.mov
Legal
This project is available under the Apache 2.0 License.