Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for table #215

Merged
merged 1 commit into from
Aug 26, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions packages/table/babel.config.cjs
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
// Don't process node_modules except for AWS UI.
module.exports = {
ignore: [/node_modules\/?!@awsui\/components-react/],
presets: ['@babel/preset-env'],
};
13 changes: 12 additions & 1 deletion packages/table/jest.config.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,12 @@ module.exports = {
'\\.(css|scss|svg)$': 'identity-obj-proxy',
'd3-array': '<rootDir>/node_modules/d3-array/dist/d3-array.min.js',
},

transform: {
'.+\\.js$': 'babel-jest',
},
transformIgnorePatterns: [
'node_modules/(?!@awsui/components-react)/',
],
coverageThreshold: {
global: {
statements: 80,
Expand All @@ -20,4 +25,10 @@ module.exports = {
lines: 80,
},
},
extensionsToTreatAsEsm: ['.ts'],
globals: {
'ts-jest': {
useESM: true,
},
},
};
2 changes: 2 additions & 0 deletions packages/table/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,10 @@
"devDependencies": {
"@aws-sdk/client-iotsitewise": "^3.39.0",
"@awsui/design-tokens": "^3.0.0",
"@babel/preset-env": "^7.18.10",
"@rollup/plugin-typescript": "^8.3.2",
"@types/jest": "^28.1.0",
"babel-jest": "^29.0.1",
"eslint-config-airbnb": "^18.2.1",
"eslint-config-airbnb-typescript": "^12.3.1",
"jest": "^28.1.0",
Expand Down
179 changes: 179 additions & 0 deletions packages/table/src/table/index.spec.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,179 @@
import React from 'react';
import * as ReactDOM from 'react-dom';
import { act } from 'react-dom/test-utils';
import { DataStream, Viewport } from '@iot-app-kit/core';
import { Annotations, COMPARISON_OPERATOR, getThresholds, StatusIcon } from '@synchro-charts/core';
import { ColumnDefinition, createTableItems, DefaultTableMessages, Item } from '../utils';
import { Table } from './index';

globalThis.IS_REACT_ACT_ENVIRONMENT = true;
const dataStreamId = 'datastream-1';
const dataStream: DataStream = {
id: dataStreamId,
data: [
{ x: new Date(2021, 1, 1).getTime(), y: 100 },
{ x: new Date(2022, 1, 1).getTime(), y: 200 },
],
resolution: 0,
};

const items: Item[] = [
{
value: {
$cellRef: {
id: dataStreamId,
resolution: 0,
},
},
},
];

const columnDefinitions: ColumnDefinition[] = [
{
header: 'value',
key: 'value',
},
];

let container: HTMLDivElement;

beforeEach(() => {
container = document.createElement('div');
document.body.appendChild(container);
});

afterEach(() => {
act(() => {
ReactDOM.unmountComponentAtNode(container);
container.remove();
});
});

it('renders correct data when viewport defined by duration', async () => {
const tableItems = createTableItems(
{
dataStreams: [dataStream],
items,
viewport: {
duration: '1000',
},
},
DefaultTableMessages
);

act(() => {
ReactDOM.render(
<Table columnDefinitions={columnDefinitions} messageOverrides={DefaultTableMessages} items={tableItems} />,
container
);
});

const cell = container.getElementsByClassName('iot-table-cell').item(0) as HTMLDivElement;
expect(cell.innerHTML).toMatch('200');
});

it('renders correct data when the viewport defined by start and end time', async () => {
const viewport: Viewport = {
start: new Date(2021, 0, 0, 0, 0, 0),
end: new Date(2021, 12, 30, 0, 0, 0),
};
const tableItems = createTableItems({ dataStreams: [dataStream], items, viewport }, DefaultTableMessages);
act(() => {
ReactDOM.render(
<Table columnDefinitions={columnDefinitions} messageOverrides={DefaultTableMessages} items={tableItems} />,
container
);
});

const cell = container.getElementsByClassName('iot-table-cell').item(0) as HTMLDivElement;
expect(cell.innerHTML).toMatch('100');
});

it('renders loading circle when datastream is in loading state', async () => {
const loadingDatastream: DataStream = {
isLoading: true,
data: [],
id: dataStreamId,
resolution: 0,
};
const tableItems = createTableItems(
{ dataStreams: [loadingDatastream], items, viewport: { duration: '1000' } },
DefaultTableMessages
);

act(() => {
ReactDOM.render(
<Table columnDefinitions={columnDefinitions} messageOverrides={DefaultTableMessages} items={tableItems} />,
container
);
});

const svg = container.getElementsByTagName('svg').item(0) as SVGElement;
expect(svg).toBeTruthy();
});

it('renders icon and applies style when a datastream breaches threshold', async () => {
const annotations: Annotations = {
y: [
{
color: 'red',
value: 30,
comparisonOperator: COMPARISON_OPERATOR.GREATER_THAN,
icon: StatusIcon.ERROR,
dataStreamIds: [dataStreamId],
},
],
};
const tableItems = createTableItems(
{ dataStreams: [dataStream], items, viewport: { duration: '1000' }, thresholds: getThresholds(annotations) },
DefaultTableMessages
);

act(() => {
ReactDOM.render(
<Table columnDefinitions={columnDefinitions} messageOverrides={DefaultTableMessages} items={tableItems} />,
container
);
});

const cell = container.getElementsByClassName('iot-table-cell').item(0) as HTMLDivElement;
expect(cell.style.color).toEqual('red');
const iconContainer = cell.childNodes.item(0);
expect(iconContainer).toBeTruthy();
const text = cell.childNodes.item(1) as Text;
expect(text.wholeText).toMatch('200');
});

it('renders icon and displays error message when datastream is in error state', () => {
const tableItems = createTableItems(
{
dataStreams: [
{
data: [],
id: dataStreamId,
error: {
msg: 'Error',
},
resolution: 0,
},
],
items,
viewport: { duration: '1000' },
},
DefaultTableMessages
);

act(() => {
ReactDOM.render(
<Table columnDefinitions={columnDefinitions} messageOverrides={DefaultTableMessages} items={tableItems} />,
container
);
});

const cell = container.getElementsByClassName('iot-table-cell').item(0) as HTMLDivElement;
const iconContainer = cell.childNodes.item(0);
expect(iconContainer).toBeTruthy();

const text = cell.childNodes.item(1) as Text;
expect(text.wholeText).toMatch('Error');
});
3 changes: 1 addition & 2 deletions packages/table/src/utils/types.ts
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Annotations, Primitive, Threshold } from '@synchro-charts/core';
import { Primitive, Threshold } from '@synchro-charts/core';
import { ErrorDetails } from '@iot-app-kit/core';
import { TableProps as AWSUITableProps } from '@awsui/components-react';
import { UseCollectionOptions } from '@awsui/collection-hooks/dist/cjs/interfaces';
Expand Down Expand Up @@ -46,7 +46,6 @@ export type CellProps = {
};

export interface TableProps extends Omit<AWSUITableProps<TableItem>, 'columnDefinitions'> {
annotations?: Annotations;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happened here?

columnDefinitions: ColumnDefinition[];
sorting?: UseCollectionOptions<TableItem>['sorting'];
propertyFiltering?: UseCollectionOptions<TableItem>['propertyFiltering'];
Expand Down
Loading