feat: add supports of filtering and sorting to iot-table #184

square-li · 2022-07-29T20:49:12Z

Overview

Release Table component V2. Adding supports for filtering and sorting.

Tests

[Include a link to the passing GitHub action running the test suite here.]

Legal

This project is available under the Apache 2.0 License.

- config typescript & rollup - config jest - config eslint - add unit tests for createTableItems method - updated .eslintrc.js at project root level

- remove unused variables.

- update descriptions for tests in createTableItems.spec.ts - add one test case for getting data point from aggregated datastream

- add createCellItem function - add unit tests for createCellItem - rename SC_DataStream to SynchroChartsDataStream for better consistency

- update createCellItem tests.

feat: set up table package and add createTableItems method

- iconUtils.tsx - copied from synchro-charts with changes. - iconUtils.spec.ts - copied from synchro-charts with changes: -- add one test cases, that color are provided, compared with the original. - spinner.tsx - copied from synchro-charts with adjustments for React - spinner.spec.tsx - copied from synchro-charts with adjustments for React

Add new Table component

- add new test case for default cell function - fix an issue when property if missing from tableItem. - update default cell function

* feat: Replace iot-table with new version. * Update autogenerated types * fix import * another fix for import * another fix for import * Remove unused property for Iot. * Fix a typo * Code cleanups. * Code cleanups. * update type of `ColumnDefinition.formatter` also added a few use cases in testing-ground.tsx * update type of `ColumnDefinition.formatter` also added a few use cases in testing-ground.tsx * Update asset/property IDs and table examples. * update: add formatter to filterOptions Property filtering options now has the same displayed value as table. * update formatPropertyFilterOptions function to better handle error & loading states. * update test examples for table component. * Disable Customized formatter for property filter options. * update test cases after disabled formatter for filter options * Remove unused dependency. * a few bug fixes - Split sorting and propertyFiltering - Remove formatting on property filtering options. * UI adjustment - center icon and string vertically. * Update styles and unit tests * Remove unused imports and statements. * Reformat css file * Restore testing ground

* Update docs. Add README.md for new table component.

# Conflicts: # packages/components/package.json # packages/components/src/components.d.ts # packages/components/src/components/iot-table/iot-table.tsx # packages/components/src/testing/testing-ground/siteWiseQueries.ts # packages/components/src/testing/testing-ground/testing-ground.tsx # yarn.lock

lgtm-com · 2022-07-29T21:04:39Z

This pull request introduces 1 alert when merging edd73ee into c80bf86 - view on LGTM.com

new alerts:

1 for Polynomial regular expression used on uncontrolled data

lgtm-com · 2022-07-29T21:34:08Z

This pull request introduces 1 alert when merging d177e2d into c80bf86 - view on LGTM.com

new alerts:

1 for Polynomial regular expression used on uncontrolled data

lgtm-com · 2022-08-02T20:17:21Z

This pull request introduces 1 alert when merging ed682e9 into 4cc2786 - view on LGTM.com

new alerts:

1 for Polynomial regular expression used on uncontrolled data

docs/Table.md

packages/table/src/utils/createCellItem.spec.ts

packages/table/src/utils/createCellItem.ts

packages/table/src/utils/tableHelpers.tsx

packages/table/src/table/index.tsx

diehbria · 2022-08-02T21:40:19Z

Should this be a major version change with documented changes in the change logs?

diehbria · 2022-08-02T21:54:02Z

are there any tests related to displaying non-latest data when there are cached more recent data (i.e. that the cells don't simply always display the latest data point, as KPI/Grid/Old table did

tracy-french · 2022-08-17T22:08:18Z

What are the next steps to merge this PR in?

square-li · 2022-08-23T19:04:16Z

Adding supports of messageOverrrides by this PR: #211.
Other requested changes will be added shortly as separated PRs also.

square-li · 2022-08-24T18:28:35Z

Updating docs and bump version by this PR: #213

lgtm-com · 2022-08-25T18:35:54Z

This pull request introduces 1 alert when merging 1b54f6e into 0edf35c - view on LGTM.com

new alerts:

1 for Polynomial regular expression used on uncontrolled data

lgtm-com · 2022-08-25T19:16:22Z

This pull request introduces 1 alert when merging 6ae7312 into 0edf35c - view on LGTM.com

new alerts:

1 for Polynomial regular expression used on uncontrolled data

- render correct data based on different viewports - render spinner when a datastream is loading - render error icon and message when a datastream in error state - render icon and apply styles when it breaches thresholds

lgtm-com · 2022-08-26T22:45:40Z

This pull request introduces 1 alert when merging 48b92de into 0edf35c - view on LGTM.com

new alerts:

1 for Polynomial regular expression used on uncontrolled data

lgtm-com · 2022-08-29T17:38:11Z

This pull request introduces 1 alert when merging ccac1c5 into 0edf35c - view on LGTM.com

new alerts:

1 for Polynomial regular expression used on uncontrolled data

lgtm-com · 2022-08-29T18:13:00Z

This pull request introduces 1 alert when merging 1f4bf90 into 0edf35c - view on LGTM.com

new alerts:

1 for Polynomial regular expression used on uncontrolled data

square-li · 2022-08-29T22:05:28Z

Closing this PR.
New PR with git history cleaned up: #221

square-li and others added 23 commits June 13, 2022 10:41

feat: set up table package and add createTableItems method

14320e2

- config typescript & rollup - config jest - config eslint - add unit tests for createTableItems method - updated .eslintrc.js at project root level

fix: update tsconfig path in eslintrc for Table package.

1e43ae6

- remove unused variables.

fix: add tests for dataFilters.ts

8304de5

- update descriptions for tests in createTableItems.spec.ts - add one test case for getting data point from aggregated datastream

fix: remove unnecessary describe block

b484a81

fix: use object to replace CellItem class

7f1e632

- add createCellItem function - add unit tests for createCellItem - rename SC_DataStream to SynchroChartsDataStream for better consistency

fix: remove unused import

36cbe94

- update createCellItem tests.

Merge pull request #124 from square-li/feature-table

c6ebbeb

feat: set up table package and add createTableItems method

feat: add the main table component

47ff45b

fix: remove generic types for TableProps

ce9422d

fix: add size to loading spinner

0585556

Merge branch 'feature-table' into feature-table

a480de6

fix: remove unnecessary TS compiler options

4b3861a

update a few things based on comments from PR.

2d5e133

Fix: remove full file eslint disable. Switch to minimal eslint disable.

0595b12

Merge pull request #129 from square-li/feature-table

92faf44

Add new Table component

Update: bounce version number to match other packages, and more...

7eeaccd

- add new test case for default cell function - fix an issue when property if missing from tableItem. - update default cell function

fix: remove unused variables.

b790b5d

Merge pull request #146 from square-li/feature-table

318f772

Merge changes from mainline and other changes: (#169)

c00a30f

Update docs. Add README.md for new table component. (#165)

a16dbb5

* Update docs. Add README.md for new table component.

bugfix: add missing brackets. (#183)

29296ca

square-li changed the title ~~Feature table~~ Table component v2 Jul 29, 2022

Merge from main and rebuild. (#186)

d177e2d

square-li marked this pull request as ready for review August 2, 2022 16:59

Merge branch 'main' into feature-table

ed682e9

diehbria requested changes Aug 2, 2022

View reviewed changes

Update docs for Table. Major version bump for breaking changes.

1b54f6e

Add messageOverrides for table.

6ae7312

add tests for table

48b92de

- render correct data based on different viewports - render spinner when a datastream is loading - render error icon and message when a datastream in error state - render icon and apply styles when it breaches thresholds

Update docs. Remove unnecessary jest configuration.

ccac1c5

square-li changed the title ~~Table component v2~~ feat: add supports of filtering and sorting to iot-table Aug 29, 2022

Merge branch 'main' into feature-table

1f4bf90

square-li requested a review from diehbria August 29, 2022 19:27

square-li mentioned this pull request Aug 29, 2022

feat(components)!: introduce new table component #221

Merged

square-li closed this Aug 29, 2022

square-li deleted the feature-table branch September 14, 2022 17:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: add supports of filtering and sorting to iot-table #184

feat: add supports of filtering and sorting to iot-table #184

square-li commented Jul 29, 2022 •

edited

Loading

lgtm-com bot commented Jul 29, 2022

lgtm-com bot commented Jul 29, 2022

lgtm-com bot commented Aug 2, 2022

diehbria commented Aug 2, 2022

diehbria commented Aug 2, 2022

tracy-french commented Aug 17, 2022

square-li commented Aug 23, 2022

square-li commented Aug 24, 2022

lgtm-com bot commented Aug 25, 2022

lgtm-com bot commented Aug 25, 2022

lgtm-com bot commented Aug 26, 2022

lgtm-com bot commented Aug 29, 2022

lgtm-com bot commented Aug 29, 2022

square-li commented Aug 29, 2022 •

edited

Loading

feat: add supports of filtering and sorting to iot-table #184

feat: add supports of filtering and sorting to iot-table #184

Conversation

square-li commented Jul 29, 2022 • edited Loading

Overview

Tests

Legal

lgtm-com bot commented Jul 29, 2022

lgtm-com bot commented Jul 29, 2022

lgtm-com bot commented Aug 2, 2022

diehbria commented Aug 2, 2022

diehbria commented Aug 2, 2022

tracy-french commented Aug 17, 2022

square-li commented Aug 23, 2022

square-li commented Aug 24, 2022

lgtm-com bot commented Aug 25, 2022

lgtm-com bot commented Aug 25, 2022

lgtm-com bot commented Aug 26, 2022

lgtm-com bot commented Aug 29, 2022

lgtm-com bot commented Aug 29, 2022

square-li commented Aug 29, 2022 • edited Loading

square-li commented Jul 29, 2022 •

edited

Loading

square-li commented Aug 29, 2022 •

edited

Loading