Skip to content

Commit

Permalink
feat(RemoveNodeSass): Replace node-sass dependency with a native java…
Browse files Browse the repository at this point in the history
…script implementation

`node-sass` is a wrapper around the C++ implementation `libsass` and requires `node-gyp` to build on the target platform. This creates friction from users as it often gets out of date, and/or broken by MacOS upgrades, reinstalling xcode, etc.

This replaces it with `sass` which is a pure JS implementation, and doesn't require the native bindings for your OS.
  • Loading branch information
Mitchell Lee authored and TheEvilDev committed Mar 2, 2023
1 parent e346eff commit f5ca005
Show file tree
Hide file tree
Showing 4 changed files with 306 additions and 1,356 deletions.
5 changes: 3 additions & 2 deletions examples/react-app/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@
"version": "0.1.0",
"private": true,
"dependencies": {
"@iot-app-kit/core": "*",
"@iot-app-kit/components": "*",
"@iot-app-kit/core": "*",
"@iot-app-kit/react-components": "*",
"@iot-app-kit/related-table": "*",
"@iot-app-kit/scene-composer": "*",
Expand Down Expand Up @@ -53,7 +53,8 @@
"devDependencies": {
"@tsconfig/recommended": "^1.0.1",
"node-polyfill-webpack-plugin": "^2.0.1",
"nodemon": "^2.0.19",
"react-app-rewired": "^2.2.1",
"nodemon": "^2.0.19"
"sass": "^1.58.3"
}
}
Loading

0 comments on commit f5ca005

Please sign in to comment.