-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(construct): SageMaker model deployment construct #95
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor grammar issues in the docs.
src/patterns/gen-ai/aws-model-deployment-sagemaker/architecture.png
Outdated
Show resolved
Hide resolved
|
||
import { Construct } from 'constructs'; | ||
import { Stack, StackProps, Aws } from 'aws-cdk-lib'; | ||
import { JumpStartSageMakerEndpoint, JumpStartModel, SageMakerInstanceType, HuggingFaceSageMakerEndpoint, DeepLearningContainerImage } from '@awslabs/generative-ai-cdk-constructs'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@awslabs would be replaced by @cdk-lib in public repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes :) will update the PR branch when this is merged
console.log(repositoryName); | ||
|
||
const pageSize = 1000; | ||
const hostname = '763104351884.dkr.ecr.us-west-2.amazonaws.com'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const hostname = '763104351884.dkr.ecr.us-west-2.amazonaws.com';
Are hardcoded registry and region required here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This value is used to get the list of available DLC images (https://github.com/aws/deep-learning-containers/blob/master/available_images.md)
src/patterns/gen-ai/aws-model-deployment-sagemaker/code-generation/package.json
Show resolved
Hide resolved
src/patterns/gen-ai/aws-model-deployment-sagemaker/code-generation/index.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor language changes to properly reflect the type of models that can be deployed.
Fixes #
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.