feat(construct): SageMaker model deployment construct #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
justintlewis
requested changes
Nov 14, 2023
src/patterns/gen-ai/aws-model-deployment-sagemaker/architecture.png
Outdated
Show resolved
Hide resolved
scottschreckengaust
previously approved these changes
Nov 14, 2023
|
|
||
| import { Construct } from 'constructs'; | ||
| import { Stack, StackProps, Aws } from 'aws-cdk-lib'; | ||
| import { JumpStartSageMakerEndpoint, JumpStartModel, SageMakerInstanceType, HuggingFaceSageMakerEndpoint, DeepLearningContainerImage } from '@awslabs/generative-ai-cdk-constructs'; |
There was a problem hiding this comment.
@awslabs would be replaced by @cdk-lib in public repository.
There was a problem hiding this comment.
yes :) will update the PR branch when this is merged
| console.log(repositoryName); | ||
|
|
||
| const pageSize = 1000; | ||
| const hostname = '763104351884.dkr.ecr.us-west-2.amazonaws.com'; |
There was a problem hiding this comment.
const hostname = '763104351884.dkr.ecr.us-west-2.amazonaws.com';
Are hardcoded registry and region required here?
There was a problem hiding this comment.
This value is used to get the list of available DLC images (https://github.com/aws/deep-learning-containers/blob/master/available_images.md)
src/patterns/gen-ai/aws-model-deployment-sagemaker/code-generation/package.json
Show resolved
Hide resolved
src/patterns/gen-ai/aws-model-deployment-sagemaker/code-generation/index.ts
Show resolved
Hide resolved
dineshSajwan
previously approved these changes
Nov 14, 2023
justintlewis
requested changes
Nov 14, 2023
scottschreckengaust
approved these changes
Nov 14, 2023
justintlewis
approved these changes
Nov 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.