Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Feature/ingestion construct #8

Merged
merged 12 commits into from
Oct 3, 2023
Merged

feat: Feature/ingestion construct #8

merged 12 commits into from
Oct 3, 2023

Conversation

krokoko
Copy link
Collaborator

@krokoko krokoko commented Oct 2, 2023

Fixes #

Merging ingestion construct in current state to main
Tested in dev account - end to end test

What is this ?

This merge provides:

  • The ingestion construct, modified to remove api keys and use bedrock since it is GA (no more custom models)
  • An update to the projen file to add automatically license header files to TS files when running linter
  • An update to the projen file to exempt bots from matching the PR linting rule
  • Updates to documentation

Why does it matter ?

This first construct provides the foundations for other developers in terms of project structure

What is next ?

  • Adding tests, fix bugs, updating documentation, security review on permissions, demo stack

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

scottschreckengaust
scottschreckengaust requested changes Oct 2, 2023
View reviewed changes
.projenrc.ts Outdated Show resolved Hide resolved
.projenrc.ts Show resolved Hide resolved
docs/.$emerging_tech_cdk_constructs.drawio.bkp Outdated Show resolved Hide resolved
lambda/embeddings_job/src/dependencies/boto3-1.28.57-py3-none-any.whl Outdated Show resolved Hide resolved
laithalsaadoon
laithalsaadoon approved these changes Oct 3, 2023
View reviewed changes
Copy link
Contributor

@laithalsaadoon laithalsaadoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krokoko krokoko merged commit 3fa71cd into main Oct 3, 2023
5 checks passed
@krokoko krokoko deleted the feature/ingestion_construct branch October 3, 2023 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scottschreckengaust scottschreckengaust scottschreckengaust approved these changes

@laithalsaadoon laithalsaadoon laithalsaadoon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krokoko @scottschreckengaust @laithalsaadoon