Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(global): global updates #25

Merged
merged 3 commits into from
Oct 12, 2023
Merged

feat(global): global updates #25

merged 3 commits into from
Oct 12, 2023

Conversation

krokoko
Copy link
Collaborator

@krokoko krokoko commented Oct 12, 2023

Fixes #

  • Update documentation to add a catalog of available constructs in README
  • Update qa and ingestion constructs props (strongly typed)

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the project license.

laithalsaadoon
laithalsaadoon approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@laithalsaadoon laithalsaadoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the typed props :) 👍

dineshSajwan
dineshSajwan approved these changes Oct 12, 2023
View reviewed changes
Copy link
Contributor

@dineshSajwan dineshSajwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@krokoko krokoko merged commit 5460b4e into main Oct 12, 2023
12 checks passed
@krokoko krokoko deleted the feature/global_updates branch October 12, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laithalsaadoon laithalsaadoon laithalsaadoon approved these changes

@dineshSajwan dineshSajwan dineshSajwan approved these changes

Assignees
No one assigned
Labels
valued-contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@krokoko @laithalsaadoon @dineshSajwan @emerging-tech-cdk-constructs-bot