Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(export): empty array is on one line fix #152 #250

Merged
merged 1 commit into from
May 24, 2024

Conversation

gaetan-craft
Copy link
Contributor

Issue #152

Empty array in function connectable_json came on one line even not in compact format.
This PR tests this case and act acordingly

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Signed-off-by: Gaëtan Duchaussois <gaetan.duchaussois@craft.ai>
Copy link
Contributor

@StoneDot StoneDot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing the issue. This addition ensures proper handling of empty arrays. Your contribution is appreciated. Approved.

@StoneDot StoneDot merged commit 5dfed19 into awslabs:main May 24, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants