chore: release pre-built binaries for macOS ARM #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shunsuke Suzuki <suzuki.shunsuke.1989@gmail.com>
suzuki-shunsuke
commented
May 7, 2024
StoneDot
reviewed
May 8, 2024
There was a problem hiding this comment.
Thank you for putting together this pull request. It's an excellent find!
The code looks great to me. Nevertheless, I'd like to double-check that this workflow functions as intended. Do you have any test runs for this new workflow?
Feel free to look at #220 (comment) for your reference as a sample execution.
|
Thank you for your review. https://github.com/suzuki-shunsuke/dynein/releases/tag/v0.2.2 The workflow succeeded and pre-built binaries were released properly. $ gh release view -R suzuki-shunsuke/dynein --json assets v0.2.2 -q '.assets[].name'
dynein-linux-arm.tar.gz
dynein-linux-arm.tar.gz.sha256
dynein-linux.tar.gz
dynein-linux.tar.gz.sha256
dynein-macos-arm.tar.gz
dynein-macos-arm.tar.gz.sha256
dynein-macos.tar.gz
dynein-macos.tar.gz.sha256
dynein-windows.zip
dynein-windows.zip.sha256 |
StoneDot
approved these changes
May 8, 2024
KIrie-0217
pushed a commit
to KIrie-0217/dynein
that referenced
this pull request
May 15, 2024
Signed-off-by: Shunsuke Suzuki <suzuki.shunsuke.1989@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
Build and release pre-built binaries for macOS ARM.
Asset name:
dynein-macos-arm.tar.gzBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.