Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add integration test for del #144

Merged
merged 1 commit into from
Aug 24, 2023

Conversation

ryota-sakamoto
Copy link
Contributor

Issue #, if available:

#143

Description of changes:

I have added the test for dy del because the test is nothing.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@ryota-sakamoto ryota-sakamoto force-pushed the integration-test-del branch 4 times, most recently from 240a676 to 231e0ce Compare July 13, 2023 11:27
@ryota-sakamoto ryota-sakamoto marked this pull request as ready for review July 13, 2023 14:12
@StoneDot StoneDot self-requested a review July 27, 2023 09:12
Copy link
Contributor

@StoneDot StoneDot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm sorry for the delay in the review. Could you check the comments?

tests/del.rs Outdated Show resolved Hide resolved
tests/util/mod.rs Show resolved Hide resolved
tests/util/mod.rs Outdated Show resolved Hide resolved
tests/del.rs Outdated Show resolved Hide resolved
tests/del.rs Outdated Show resolved Hide resolved
@ryota-sakamoto ryota-sakamoto force-pushed the integration-test-del branch 5 times, most recently from 7cc9e82 to 214b9b2 Compare August 17, 2023 17:51
@ryota-sakamoto ryota-sakamoto force-pushed the integration-test-del branch 2 times, most recently from f436f18 to 7192c05 Compare August 17, 2023 18:18
@StoneDot
Copy link
Contributor

All discussions are resolved. And It seems good to me. I will merge this PR. Thank you for your patience of my delay in the review.

tests/util/mod.rs Show resolved Hide resolved
@StoneDot StoneDot merged commit fa997ea into awslabs:main Aug 24, 2023
2 checks passed
@ryota-sakamoto ryota-sakamoto deleted the integration-test-del branch August 24, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants