Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade SNAFU to 0.7 #115

Merged
merged 1 commit into from
Jan 6, 2022
Merged

Upgrade SNAFU to 0.7 #115

merged 1 commit into from
Jan 6, 2022

Conversation

shepmaster
Copy link
Contributor

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@shepmaster
Copy link
Contributor Author

Looks like some formatting changes (as the selector names are a bit longer now) I can run rustfmt and force-push.

Copy link
Contributor

@jpculp jpculp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thank you for submitting this!

I did a quick upload/download test and everything looked OK.

@jpculp jpculp requested review from bcressey and zmrow January 4, 2022 20:57
Copy link
Contributor

@webern webern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pro-actively updating your clients!

@shepmaster
Copy link
Contributor Author

pro-actively updating your clients

It's a mutual thing — I used your crate (and others!) via a crater-like tool to create and test the auto-upgrade tool, so then it was easy to submit the PR. 😉

Copy link
Contributor

@cbgbt cbgbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was really nice of you to send these update PRs. Thank you!

Copy link
Contributor

@bcressey bcressey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@jpculp jpculp merged commit e9fa869 into awslabs:develop Jan 6, 2022
@shepmaster shepmaster deleted the snafu-0.7 branch January 6, 2022 02:29
@shepmaster
Copy link
Contributor Author

Thanks for using SNAFU!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants