Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Redact Mode Names #18

Closed
taylorb-syd opened this issue Feb 14, 2021 · 2 comments
Closed

Change Redact Mode Names #18

taylorb-syd opened this issue Feb 14, 2021 · 2 comments
Assignees
Milestone

Comments

@taylorb-syd
Copy link
Contributor

"Blacklist" and "Whitelist" have negative connotations, so need to change them to something more acceptable like "Allowlist" and "Blocklist".

Will need to include "Blacklist" and "Whitelist" in library, but unmentioned in documentation, for backwards compatibility. Probably best to put a redundancy message in the logs, and remove at a future date.

@taylorb-syd taylorb-syd self-assigned this Feb 14, 2021
@taylorb-syd taylorb-syd added this to the 2.0 milestone Feb 14, 2021
taylorb-syd added a commit that referenced this issue Feb 15, 2021
…tored Code, Improved Testing Code, Improved README.md grammar
@taylorb-syd
Copy link
Contributor Author

Ready to merge from issue-18 branch.

@taylorb-syd
Copy link
Contributor Author

Merged into main. Closing out issue awaiting PR.

taylorb-syd added a commit that referenced this issue Feb 15, 2021
taylorb-syd added a commit that referenced this issue Feb 15, 2023
* [Issue #18] Changed Whitelist/Blacklist to Allowlist/Blocklist, Refactored Code, Improved Testing Code, Improved README.md grammar

* [Issue #3] Introduced logic to check size of response. Refactored decorator exception handling.

* [Issue #4] Introduced a function to collapse the output data and used this in the cfnresponse function

* [1.2.0rc1] Documentation Pass to improve README.md

* [Issue #2] Implemented Unit Tests

* [Issue #21] Added the response headers for troubleshooting to the debug log output
taylorb-syd added a commit that referenced this issue Feb 15, 2023
* [Issue #18] Changed Whitelist/Blacklist to Allowlist/Blocklist, Refactored Code, Improved Testing Code, Improved README.md grammar

* [Issue #3] Introduced logic to check size of response. Refactored decorator exception handling.

* [Issue #4] Introduced a function to collapse the output data and used this in the cfnresponse function

* [1.2.0rc1] Documentation Pass to improve README.md

* [Issue #2] Implemented Unit Tests

* [Issue #21] Added the response headers for troubleshooting to the debug log output
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant