Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

botocore.vendored.requests is becoming deprecated #11

Closed
taylorb-syd opened this issue Jun 26, 2019 · 3 comments
Closed

botocore.vendored.requests is becoming deprecated #11

taylorb-syd opened this issue Jun 26, 2019 · 3 comments
Assignees
@taylorb-syd
Labels
bug

Comments

@taylorb-syd
Copy link
Contributor

It looks like botocore.vendored.requests is being deprecated from botocore. We should instead move towards using requests directly.

This may increase the complexity of installing, so maybe I should vendor a copy of requests directly in the library. Need to review options.
@taylorb-syd taylorb-syd self-assigned this Jun 26, 2019
@taylorb-syd taylorb-syd added this to the 2.0 milestone Jun 26, 2019
@NightKhaos NightKhaos modified the milestones: 2.0, 1.1 Aug 5, 2019
@taylorb-syd
Copy link
Contributor Author

Decided not to include the vendored copy as request is a bit of a mess in terms of other dependencies and finding a way to reliably vend the library may be difficult.

taylorb-syd added a commit that referenced this issue Jan 8, 2020
@taylorb-syd
Requests migration and testing logic (#13)
b3c6168 
* Moved to requests instead of botocore.vendored requests and started implementing response testing

* typo in docs

Implements #11
@taylorb-syd
Copy link
Contributor Author

Waiting for 1.1 release

@taylorb-syd
Copy link
Contributor Author

3.8 Lambda environment uses an old version of botocore. Used this to test, and confident new logic works. Waiting for 1.1 release.

@taylorb-syd taylorb-syd mentioned this issue Jan 9, 2020
Merged
taylorb-syd added a commit that referenced this issue Jan 9, 2020
@taylorb-syd
[1.1.0] Merging completed milestones for 1.1 (#14)
5b2ae14 
Implements:

- #1 Redaction of `DEBUG` event printing interface to prevent information leaks in logs.
- #5 Chained Lambda Invocations with Timeout Support
- #11 Removes dependency on `botocore.vendored.requests` allowing for Python3.8 based Lambda support.
- #2 (Partial) Includes some new Unit Tests and Functional Tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@taylorb-syd taylorb-syd

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@NightKhaos @taylorb-syd