Bump rustdoc-types to v25 #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jdisanti
reviewed
May 3, 2024
src/visitor.rs
Outdated
| @@ -402,6 +402,8 @@ impl Visitor { | |||
| } | |||
| Type::Generic(_) => {} | |||
| Type::Primitive(_) => {} | |||
| // Pattern types are unstable and rustc internal rust-lang#120131 | |||
| Type::Pat { .. } => {} | |||
There was a problem hiding this comment.
So far we've been supporting unstable compiler features in the event they stabilize. I'm fine with not supporting pattern types, but ideally it would panic rather than silently ignore the inner type.
There was a problem hiding this comment.
That makes sense. I've added a panic 👍
https://github.com/awslabs/cargo-check-external-types/compare/47b98dd4eea02026f5eb4e71142752350e6234d2..fb36e66e295c331089a2a957ac9c65eb5a65209f
eopb
force-pushed
the
push-xnqymwxqrttn
branch
3 times, most recently
from
fb36e66 to
c0efb07
Compare
When using `cargo-check-external-types` with the latest nightly release I saw: ``` The version of rustdoc being used produces JSON format version 29, but this tool requires format version 28. This can happen if the locally installed version of rustdoc doesn't match the rustdoc JSON types from the `rustdoc-types` crate. If this occurs with the latest Rust nightly and the latest version of this tool, then this is a bug, and the tool needs to be upgraded to the latest format version. Otherwise, you'll need to determine a Rust nightly version that matches this tool's supported format version (or vice versa). ``` This change adds support for the most recent nightly versions using rustdoc format version 29. The changelog for `rustdoc-types` can be found here https://github.com/aDotInTheVoid/rustdoc-types/blob/trunk/CHANGELOG.md#v0250---2024-04-19
|
Hey @jdisanti |
jdisanti
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
cargo-check-external-typeswith the latest nightly release I saw:This change adds support for the most recent nightly versions using rustdoc format version 29.
The changelog for
rustdoc-typescan be found here https://github.com/aDotInTheVoid/rustdoc-types/blob/trunk/CHANGELOG.md#v0250---2024-04-19By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.