New Pattern: aws-kinesisstreams-gluejob #122
Conversation
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
| * "comment": "Some value associated with the record" | ||
| * }, | ||
| * | ||
| * @default |
There was a problem hiding this comment.
If there is no default, use
* @default - None
| readonly outputDataStore?: defaults.SinkDataStoreProps; | ||
| } | ||
|
|
||
| export class KinesisStreamGlueJob extends Construct { |
There was a problem hiding this comment.
Hate to do this to you, we should have caught this last time - but this class name should be KinesisstreamsToGluejob
The "To" has been standard everywhere. The pure Pascal casing is something we clarified and documented over the past 2 weeks. If it was just the casing we wouldn't ask you to go back and change - but we gotta have the To.
There was a problem hiding this comment.
@biffgaut , would also request if you can check the java and python package naming conventions.
| readonly outputDataStore?: defaults.SinkDataStoreProps; | ||
| } | ||
|
|
||
| export class KinesisStreamGlueJob extends Construct { |
There was a problem hiding this comment.
I'm seeing about 50% of the classes have an @summary comment, but since that comment is always:
/**
* @summary The SnsToLambda class.
*/
export class SnsToLambda extends Construct {
I'm OK leaving it out.
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue #: #40
Description of changes: Added a new construct to create a streaming glue etl job, that sources data from Amazon Kinesis Data Stream and writes to an S3 bucket. With the default set of parameters, the construct creates an Amazon Kinesis Data Stream, AWS Glue Job, AWS Glue Database, AWS Glue Table, IAM Role with policies required for the job, an output S3 bucket as well an asset based S3 bucket for the ETL script.
The pull request also has a working example under use cases folder on using this construct.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.