Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Set outputBucket on aws-kinesisstreams-gluejob): Property is currently not set #448

Closed
biffgaut opened this issue Oct 12, 2021 · 0 comments · Fixed by #452
Closed

fix(Set outputBucket on aws-kinesisstreams-gluejob): Property is currently not set #448

biffgaut opened this issue Oct 12, 2021 · 0 comments · Fixed by #452
Labels
bug Something isn't working needs-triage The issue or PR still needs to be triaged

Comments

@biffgaut
Copy link
Contributor

The output bucket created in deployGlueJob is not returned to the construct, so is not available to set this property.

Reproduction Steps

Error Log

Environment

  • CDK CLI Version :
  • CDK Framework Version:
  • AWS Solutions Constructs Version :
  • OS :
  • Language :

Other

This is 🐛 Bug Report
@biffgaut biffgaut added bug Something isn't working needs-triage The issue or PR still needs to be triaged labels Oct 12, 2021
@knihit knihit mentioned this issue Oct 12, 2021
Merged
@biffgaut biffgaut linked a pull request Oct 12, 2021 that will close this issue
Fix(Set outputBucket property on aws-kinesisstreams-gluejob): Issue #448 to include S3 bucket for Glue Job that the consturct creates #452
Merged
biffgaut added a commit that referenced this issue Oct 12, 2021
@knihit @biffgaut
Fix(Set outputBucket property on aws-kinesisstreams-gluejob): Issue #448
c40e1f7 
 to include S3 bucket for Glue Job that the consturct creates (#452)

* update glue max allocation units to 2

* update glue max allocation units to 2

* resolving workerType and maxCapacity config related rules

* resolving workerType and maxCapacity config related rules

* resolving workerType and maxCapacity config related rules

* removing additional lines from the file

* fix snapshots for glue helper

* fix snapshots for glue helper

* fix snapshots for glue helper

* fix snapshots for glue helper

* fix snapshots for glue helper

* fix snapshots for glue helper

* documentation rephrase

* new construct first commit with README and architecture

* adding minimal deployable code to README

* adding minimal deployable code to README

* fix for github issue #448

Co-authored-by: nihitkas <nihitkas@amazon.com>
Co-authored-by: biffgaut <78155736+biffgaut@users.noreply.github.com>
biffgaut added a commit that referenced this issue Feb 25, 2022
@knihit @biffgaut
fix(Python module name for Kinesis Firehose S3 pattern is not correct…
68b49af 
…: Update Python module name for aws-kinesisfirehose-s3 (#592)

* update glue max allocation units to 2

* update glue max allocation units to 2

* resolving workerType and maxCapacity config related rules

* resolving workerType and maxCapacity config related rules

* resolving workerType and maxCapacity config related rules

* removing additional lines from the file

* fix snapshots for glue helper

* fix snapshots for glue helper

* fix snapshots for glue helper

* fix snapshots for glue helper

* fix snapshots for glue helper

* fix snapshots for glue helper

* documentation rephrase

* new construct first commit with README and architecture

* adding minimal deployable code to README

* adding minimal deployable code to README

* fix for github issue #448

* python module name correction

The python module name has `-` instead of `_`. Update the readme with the correct python module names

Co-authored-by: nihitkas <nihitkas@amazon.com>
Co-authored-by: biffgaut <78155736+biffgaut@users.noreply.github.com>
biffgaut added a commit that referenced this issue Mar 29, 2022
@knihit @biffgaut
Fix Glue Job ETL for CDK V2 (#634)
7dbf51a 
* update glue max allocation units to 2

* update glue max allocation units to 2

* resolving workerType and maxCapacity config related rules

* resolving workerType and maxCapacity config related rules

* resolving workerType and maxCapacity config related rules

* removing additional lines from the file

* fix snapshots for glue helper

* fix snapshots for glue helper

* fix snapshots for glue helper

* fix snapshots for glue helper

* fix snapshots for glue helper

* fix snapshots for glue helper

* documentation rephrase

* new construct first commit with README and architecture

* adding minimal deployable code to README

* adding minimal deployable code to README

* fix for github issue #448

* python module name correction

The python module name has `-` instead of `_`. Update the readme with the correct python module names

* fix for changes with CDK V2 for use with Asset instances

* update sample use case for glue job etl

* fix CDK V2 unit test failures

* update formatting for code file

* update formatting for code file

* update formatting for code file

* fix for CDK V2 unit test failures

* fix for CDK V2 unit test failures

* incorporate review comments

* fixed unit test failure for glue job helper

* update linting for glue job construct

* fix unit test failure

* fix unit test failure

Co-authored-by: nihitkas <nihitkas@amazon.com>
Co-authored-by: biffgaut <78155736+biffgaut@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working needs-triage The issue or PR still needs to be triaged
Projects
None yet
Milestone
No milestone
1 participant
@biffgaut