Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove trailing whitespaces in all Swift files #819

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

ganeshnj
Copy link
Contributor

@ganeshnj ganeshnj commented Jan 12, 2023

Issue #

Description of changes

Getting rid of some annoyance.

find . -name "*.swift" -print0 | xargs -0 sed -i '' -E "s/[[:space:]]*$//"

New/existing dependencies impact assessment, if applicable

Conventional Commits

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ganeshnj ganeshnj requested a review from epau January 12, 2023 00:27
@@ -6,7 +6,6 @@ analyzer_rules:
- unused_declaration

disabled_rules:
- trailing_whitespace
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why was this rule disabled in the first place? I generally hate picky linter settings, but this is one of the few rules I would want to have.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

likely because there were tons of places to be fixed

@ganeshnj ganeshnj merged commit 6d7c4a1 into main Jan 12, 2023
@ganeshnj ganeshnj deleted the jangirg/chore/swiftlint-fixes branch January 12, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants