Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove try from non-throwing method calls #809

Merged
merged 3 commits into from
Jan 6, 2023

Conversation

jbelkins
Copy link
Contributor

@jbelkins jbelkins commented Jan 5, 2023

Issue #

Fixes #807

Description of changes

DefaultEndpointResolver for each service is throwing three compile warnings due to the use of try on non-throwing method calls. This PR removes try where it is not needed, eliminating these warnings.

New/existing dependencies impact assessment, if applicable

No new dependencies were added to this change.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jbelkins jbelkins marked this pull request as ready for review January 5, 2023 23:31
@jbelkins jbelkins requested review from ganeshnj and epau January 5, 2023 23:32
@jbelkins jbelkins merged commit c31f67f into main Jan 6, 2023
@jbelkins jbelkins deleted the jbe/endpoint_resolver_dont_try branch January 6, 2023 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DefaultEndpointResolver throws compile warnings
3 participants