chore: aws-sdk-swift package structuring #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
epau
reviewed
Jan 5, 2023
Still working on it, I plan to put generated services in |
ganeshnj
force-pushed
the
jangirg/chore/package-restruct
branch
7 times, most recently
from
1331711
to
caadd01
Compare
ganeshnj
force-pushed
the
jangirg/chore/package-restruct
branch
from
caadd01
to
5add24b
Compare
epau
reviewed
Jan 10, 2023
epau
reviewed
Jan 10, 2023
epau
reviewed
Jan 10, 2023
epau
reviewed
Jan 10, 2023
epau
approved these changes
Jan 10, 2023
added 3 commits
January 10, 2023 09:51
jbelkins
requested changes
Jan 10, 2023
jbelkins
approved these changes
Jan 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #
Fixes #776
Description of changes
Companion PR smithy-lang/smithy-swift#503
This PR foundation for testing story.
The repo now looks like
In future we will add Integration following the same structure.
I had trouble with getting the checks passed when any service test is enabled. swift cli fatal fails. I'm going to cut an issue to Swift team about it. However, devs can uncomment any test target and use it in Xcode without any problem.
Refrain to review Services dirs.
New/existing dependencies impact assessment, if applicable
Conventional Commits
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.